Change looks fine.
Do you need me pushing it for you?
Thanks
Max
On 03/07/2017 06:40 PM, Sergei Kovalev wrote:
Good point. For same reason I've removed module declaration from
PrincipalSystemPropTest.java. Now it uses TETS.properties config. Please
take a look.
http://cr.openjdk.java.net/~sko
Good point. For same reason I've removed module declaration from
PrincipalSystemPropTest.java. Now it uses TETS.properties config. Please
take a look.
http://cr.openjdk.java.net/~skovalev/8176213/webrev.01/
07.03.17 13:30, Weijun Wang wrote:
On 03/07/2017 05:50 PM, Sergei Kovalev wrote:
H
On 03/07/2017 05:50 PM, Sergei Kovalev wrote:
Hi Max,
Thank you for review.
07.03.17 02:15, Weijun Wang wrote:
Hi Sergei
Two questions:
1. Can we remove the @modules section in Renew.java so that it uses
the one in TEST.properties?
We can however TEST.properties contains jdk.security.jgs
Hi Max,
Thank you for review.
07.03.17 02:15, Weijun Wang wrote:
Hi Sergei
Two questions:
1. Can we remove the @modules section in Renew.java so that it uses
the one in TEST.properties?
We can however TEST.properties contains jdk.security.jgss module
dependency but Renew.java doesn't. If w
Hi Sergei
Two questions:
1. Can we remove the @modules section in Renew.java so that it uses the
one in TEST.properties?
2. I cannot see why jdk.crypto.cryptoki is necessary for
PrincipalSystemPropTest.java. What is the error?
BTW, can you tell me how to make the test fail? Maybe with some
Hello Team,
Please review small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8176213
Webrev: http://cr.openjdk.java.net/~skovalev/8176213/webrev.00
Issue: The tests failing due to undeclared dependencies on
jdk.security.auth and jdk.security.jgss.
Solution: add missed module
