Re: RFR: 8042982: Unexpected RuntimeExceptions being thrown by SSLEngine

2014-08-01 Thread Rob McKenna
Thanks Brad, patch updated, built tested. -Rob On 01/08/14 01:39, Bradford Wetmore wrote: Rob, Looks ok to me too. There are probably other places with RTE's we could fix, but this will solve the immediate problem. Two comments to consider: 1. Use a Multi-catch exception. JDK7+.

Re: RFR: 8042982: Unexpected RuntimeExceptions being thrown by SSLEngine

2014-08-01 Thread Bradford Wetmore
BTW, if you feel like it in any backports, the casts to SSLHandshakeException weren't needed. Brad On 8/1/2014 11:46 AM, Rob McKenna wrote: Thanks Brad, patch updated, built tested. -Rob On 01/08/14 01:39, Bradford Wetmore wrote: Rob, Looks ok to me too. There are probably other

Re: RFR: 8042982: Unexpected RuntimeExceptions being thrown by SSLEngine

2014-07-31 Thread Bradford Wetmore
Rob, Looks ok to me too. There are probably other places with RTE's we could fix, but this will solve the immediate problem. Two comments to consider: 1. Use a Multi-catch exception. JDK7+. 2. DHCrypt throws IOException. ECDHCrypt throws SSLException (which is an IOException). Since

Re: RFR: 8042982: Unexpected RuntimeExceptions being thrown by SSLEngine

2014-07-25 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 7/22/2014 9:37 PM, Rob McKenna wrote: Hi folks, A simple change to use SSLHandshakeException instead of RuntimeException in getAgreedSecret in DHCrypt and ECDHCrypt. This will prevent these RuntimeExceptions from propagating to the application and allow

RFR: 8042982: Unexpected RuntimeExceptions being thrown by SSLEngine

2014-07-22 Thread Rob McKenna
Hi folks, A simple change to use SSLHandshakeException instead of RuntimeException in getAgreedSecret in DHCrypt and ECDHCrypt. This will prevent these RuntimeExceptions from propagating to the application and allow application programmers to handle them as SSLHandshakeExceptions.