Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-06 Thread Stuart Marks
On Tue, 6 Oct 2020 05:07:37 GMT, Tagir F. Valeev wrote: >> Sorry to be late to the party. I thought that all reviews labeled with >> core-libs should be mirrored to core-libs-dev >> mailing list but I haven't seen it there :( >> Please note that the integrated implementation exposes

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-05 Thread Tagir F . Valeev
On Tue, 6 Oct 2020 03:10:34 GMT, Tagir F. Valeev wrote: >> Looks good, i wondered why the performance results were so slow then i >> looked more closely and saw "-Xint" was used. I >> usually don't ascribe much value to micro benchmarks run in interpreter only >> mode, but hey any shaving off

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-05 Thread Tagir F . Valeev
On Fri, 2 Oct 2020 20:38:40 GMT, Paul Sandoz wrote: >> Plumb new internal static factory method to trust the array passed in, >> avoiding unnecessary copying. JMH results for >> the benchmark show about 15% improvement for the cases that were optimized, >> namely the 3 to 10 fixed arg cases.

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Paul Sandoz
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fixed arg cases. > #

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 06:26:39 GMT, Martin Grigorov wrote: >> Plumb new internal static factory method to trust the array passed in, >> avoiding unnecessary copying. JMH results for >> the benchmark show about 15% improvement for the cases that were optimized, >> namely the 3 to 10 fixed arg

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fixed arg cases. > #

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-01 Thread Martin Grigorov
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fixed arg cases. > #

RFR: 8156071: List.of: reduce array copying during creation

2020-09-30 Thread Stuart Marks
Plumb new internal static factory method to trust the array passed in, avoiding unnecessary copying. JMH results for the benchmark show about 15% improvement for the cases that were optimized, namely the 3 to 10 fixed arg cases. # VM options: -verbose:gc -XX:+UseParallelGC -Xms4g -Xmx4g