Re: RFR: 8185855: Debug exception stacks should be clearer

2017-12-06 Thread Seán Coffey
whoops - pasted the wrong file diffs in last email : diff --git a/src/java.base/share/classes/sun/security/util/AnchorCertificates.java b/src/java.base/share/classes/sun/security/util/AnchorCertificates.java --- a/src/java.base/share/classes/sun/security/util/AnchorCertificates.java +++ b/src/

Re: RFR: 8185855: Debug exception stacks should be clearer

2017-12-06 Thread Seán Coffey
Thanks for reviewing Sean. Not finding the cacerts file has always resulted in the stacktrace going to stderr in the past. I guess there's no harm putting it behind a debug flag. New diff for that file below. I'll push later today if I hear nothing else. diff --git a/src/java.base/share/class

Re: RFR: 8185855: Debug exception stacks should be clearer

2017-12-05 Thread Anthony Scarpino
On 12/05/2017 06:27 AM, Seán Coffey wrote: Looking to improve the stacktrace output made when debug mode is enabled for java.security and sun.security classes. In the past, some of these have led to confusion for end users. Best to add some context when we're printing stacktrace for information

Re: RFR: 8185855: Debug exception stacks should be clearer

2017-12-05 Thread Sean Mullan
On 12/5/17 9:27 AM, Seán Coffey wrote: Looking to improve the stacktrace output made when debug mode is enabled for java.security and sun.security classes. In the past, some of these have led to confusion for end users. Best to add some context when we're printing stacktrace for informational,

RFR: 8185855: Debug exception stacks should be clearer

2017-12-05 Thread Seán Coffey
Looking to improve the stacktrace output made when debug mode is enabled for java.security and sun.security classes. In the past, some of these have led to confusion for end users. Best to add some context when we're printing stacktrace for informational, debug, purposes. https://bugs.openjdk.