Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-20 Thread Valerie Peng
I saw you've integrated this. Just want to add that, instead of mode (which is used also for part of the transformation, e.g. CBC, GCM), maybe we can use "operation" or "operating mode". Something to keep in mind for future changes, I guess. Regards, Valerie On 11/17/2018 11:36 PM, Weijun Wa

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-17 Thread Weijun Wang
The version looks fine. Thanks. > On Nov 17, 2018, at 1:56 AM, Seán Coffey wrote: > > Thanks Sean. StringBuilder use added : > > http://cr.openjdk.java.net/~coffeys/webrev.8210838.v4/webrev/ > > Regards, > Sean. > > On 16/11/18 17:33, Sean Mullan wrote: >> Looks ok. If there are no disadvanta

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Seán Coffey
Thanks Sean. StringBuilder use added : http://cr.openjdk.java.net/~coffeys/webrev.8210838.v4/webrev/ Regards, Sean. On 16/11/18 17:33, Sean Mullan wrote: Looks ok. If there are no disadvantages to using a StringBuilder, I would probably do that, since you are creating 4-5 separate Strings in

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Sean Mullan
Looks ok. If there are no disadvantages to using a StringBuilder, I would probably do that, since you are creating 4-5 separate Strings in the toString method. --Sean On 11/16/18 11:35 AM, Seán Coffey wrote: On 16/11/18 16:16, Sean Mullan wrote: On 11/16/18 9:04 AM, Seán Coffey wrote: That

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Seán Coffey
On 16/11/18 16:16, Sean Mullan wrote: On 11/16/18 9:04 AM, Seán Coffey wrote: That's a good example and point Max. How does this revision look ? http://cr.openjdk.java.net/~coffeys/webrev.8210838.v2/webrev/ 2832 * This implementation returns a String containing the transformation 283

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Sean Mullan
On 11/16/18 9:04 AM, Seán Coffey wrote: That's a good example and point Max. How does this revision look ? http://cr.openjdk.java.net/~coffeys/webrev.8210838.v2/webrev/ 2832 * This implementation returns a String containing the transformation 2833 * used by this Cipher, the Cipher

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Seán Coffey
webrev updated! http://cr.openjdk.java.net/~coffeys/webrev.8210838.v3/webrev/ Regards, Sean. On 16/11/18 14:19, Weijun Wang wrote: Do you want to update the init() methods to make use of this new toString() output? This avoids duplicated code and we can even inline the getOpmodeString() meth

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Weijun Wang
Do you want to update the init() methods to make use of this new toString() output? This avoids duplicated code and we can even inline the getOpmodeString() method. --Max > On Nov 16, 2018, at 10:04 PM, Seán Coffey wrote: > > That's a good example and point Max. How does this revision look ?

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-16 Thread Seán Coffey
That's a good example and point Max. How does this revision look ? http://cr.openjdk.java.net/~coffeys/webrev.8210838.v2/webrev/ Regards, Sean. On 16/11/18 03:35, Weijun Wang wrote: Signature's toString looks like public String toString() { String initState = ""; switch (state) {

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-15 Thread Weijun Wang
Signature's toString looks like public String toString() { String initState = ""; switch (state) { case UNINITIALIZED: initState = ""; break; case VERIFY: initState = ""; break; case SIGN: initState = ""; break; } return "

RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-15 Thread Seán Coffey
A simple enhancement to override toString() for javax.crypto.Cipher class https://bugs.openjdk.java.net/browse/JDK-8210838 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8210838/webrev/ regards, Sean.