On Mon, Dec 03, 2018 at 05:10:26PM +, Seán Coffey wrote:
> I made further edits to update the DNSName comment code to reference RFC
> 5280 rather than the obsoleted RFC 2459. I also updated the test case with a
> few extra tests per suggestion from Chris and others. Moved the dataprovider
>
On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote:
whoops:
latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/
Regards,
Sean.
Looks good.
-Chris.
The change looks fine to me.
Thanks
Max
> On Dec 4, 2018, at 1:11 AM, Seán Coffey wrote:
>
> whoops:
> latest webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v4/webrev/
> Regards,
> Sean.
-8207768
regards,
Sean.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: Seán Coffey
Gesendet: Freitag, November 16, 2018 5:15 PM
An: Bernd Eckenfels; security-dev@openjdk.java.net
Betreff: Re: RFR: 8213952: Relax DNSName restriction as per
RFC 1123
Thanks for the comments Bernd. comments inline..
On 16
new
`jdk.includeInExceptions` Security property which other
component areas have started to use lately.
e.g. https://bugs.openjdk.java.net/browse/JDK-8207768
regards,
Sean.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: Seán Coffey
Gesendet: Freitag, November 16, 2018 5:15 PM
An: Bernd Eckenfels
eaned up some other references to DNSName in the sun.security.x509 package.
I'm not sure what classes you were referencing the above examples from.
new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8213952.v2/webrev/
regards,
Sean.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: securi
in place :
>>>>> http://cr.openjdk.java.net/~coffeys/webrev.8213952.v2/webrev/
>>>>>
>>>>>
>>>>>> me applies to SAN or NameConstrained context and the validation logic
>>>>>> does not know — so it’s not
not know — so it’s not only more unified but also less missleading)
>>>>>
>>>>> BTW: probably not inthe scope of this fix but a subtype for validation
>>>>> errors which have getters for context/location and maybe error code and
>>>>&
her component areas have started to use lately.
e.g. https://bugs.openjdk.java.net/browse/JDK-8207768
regards,
Sean.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: Seán Coffey
Gesendet: Freitag, November 16, 2018 5:15 PM
An: Bernd Eckenfels; security-dev@openjdk.java.net
Betreff: Re: RFR:
gt; relying on the message or Stacktraces.
>>
>> That's a nice idea and one that should be followed up in separate
>> enhancement. We could lean on the new `jdk.includeInExceptions` Security
>> property which other component areas have started to use lately.
>>
>> e.g. ht
-
*Von:* Seán Coffey
*Gesendet:* Freitag, November 16, 2018 5:15 PM
*An:* Bernd Eckenfels; security-dev@openjdk.java.net
*Betreff:* Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123
Thanks for the comments Bernd. comments inline..
On 16/11/18 12:40, Bernd Eckenfe
regards,
Sean.
Gruss
Bernd
--
http://bernd.eckenfels.net
*Von:* Seán Coffey
*Gesendet:* Freitag, November 16, 2018 5:15 PM
*An:* Bernd Eckenfels; security-dev@openjdk.java.net
*Betreff:* Re: RFR: 8213952: Relax DNSName restrict
int nicer validation reports without relying on the
message or Stacktraces.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: Seán Coffey
Gesendet: Freitag, November 16, 2018 5:15 PM
An: Bernd Eckenfels; security-dev@openjdk.java.net
Betreff: Re: RFR: 8213952: Relax DNSName
: Relax DNSName restriction as per RFC 1123
Looking to make an adjustment to DNSName constructor to help comply with
RFC 1123
https://bugs.openjdk.java.net/browse/JDK-8213952
http://cr.openjdk.java.net/~coffeys/webrev.8213952/webrev/
regards,
Sean.
://bernd.eckenfels.net
Von: security-dev im Auftrag von Seán
Coffey
Gesendet: Freitag, November 16, 2018 12:25 PM
An: OpenJDK Dev list
Betreff: RFR: 8213952: Relax DNSName restriction as per RFC 1123
Looking to make an adjustment to DNSName constructor to help comply
Looking to make an adjustment to DNSName constructor to help comply with
RFC 1123
https://bugs.openjdk.java.net/browse/JDK-8213952
http://cr.openjdk.java.net/~coffeys/webrev.8213952/webrev/
regards,
Sean.
16 matches
Mail list logo