Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-09 Thread Sean Mullan
On Fri, 9 Apr 2021 19:54:22 GMT, Weijun Wang wrote: >> I'm ok with not supporting SHA-1, although adding it would not be a security >> issue. It is blocked by default now, but it can be re-enabled, and SHA-1 in >> general is still available in the JDK. >> >> I'm fine with adding support for

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-09 Thread Weijun Wang
On Fri, 9 Apr 2021 17:23:05 GMT, Sean Mullan wrote: >> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java >> line 588: >> >>> 586: >>> 587: public enum DigestAlgorithm { >>> 588: //SHA1("SHA-1",

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-09 Thread Weijun Wang
On Fri, 9 Apr 2021 16:44:07 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spec word change, no hashCode and equals, test change > >

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-09 Thread Sean Mullan
On Wed, 24 Mar 2021 21:39:28 GMT, Weijun Wang wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spec word change, no hashCode and equals, test change > >

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-09 Thread Sean Mullan
On Thu, 1 Apr 2021 13:32:47 GMT, Weijun Wang wrote: >> This enhancement contains the following code changes: >> >> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec` >> and remove the internal one. >> 2. Update marshaling and unmarshaling code inside

Re: RFR: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params [v3]

2021-04-01 Thread Weijun Wang
> This enhancement contains the following code changes: > > 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec` > and remove the internal one. > 2. Update marshaling and unmarshaling code inside `DOMRSAPSSSignatureMethod` > so it understands extra fields in