On Thu, 1 Oct 2020 14:42:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for
>> https://bugs.openjdk.java.net/browse/JDK-8242882?
>>
>> As noted in that JBS issue, if the size of the Manifest entry in the jar
>> happens to be very large (such that it exceeds
>>
On Wed, 7 Oct 2020 21:40:57 GMT, Brent Christian wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Second round of review comments addressed
>
> Marked as reviewed by bchristi (Reviewer).
Hello Lance, does the lates
On Thu, 1 Oct 2020 14:42:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for
>> https://bugs.openjdk.java.net/browse/JDK-8242882?
>>
>> As noted in that JBS issue, if the size of the Manifest entry in the jar
>> happens to be very large (such that it exceeds
>>
> Can I please get a review and a sponsor for a fix for
> https://bugs.openjdk.java.net/browse/JDK-8242882?
>
> As noted in that JBS issue, if the size of the Manifest entry in the jar
> happens to be very large (such that it exceeds
> the `Integer.MAX_VALUE`), then the current code in `JarFile#
On Wed, 30 Sep 2020 18:38:40 GMT, Lance Andersen wrote:
>> I think it's fine either way.
>
> If you are going to validate the message, which I probably would not, it
> would be important to make sure it document
> if the message is changed in JarFile::getBytes, that the test needs updated.
>
