Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-23 Thread Andrey Turbanov
On Wed, 2 Dec 2020 05:01:28 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > comments v4 src/java.base/share/classes/com/sun/crypto/provid

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-02 Thread Valerie Peng
On Wed, 2 Dec 2020 04:58:13 GMT, Anthony Scarpino wrote: >> The biggest part of this change is the addition of overlap protection and >> the tests to verify it for GCM, as there were none in the open repo. >> Additionally, GCMBufferTest had some significant changes to clean it up and >> handl

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-02 Thread Valerie Peng
On Wed, 2 Dec 2020 05:01:28 GMT, Anthony Scarpino wrote: >> 8253821: Improve ByteBuffer performance with GCM > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > comments v4 Marked as reviewed by valeriep (Reviewer). -

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-01 Thread Anthony Scarpino
> 8253821: Improve ByteBuffer performance with GCM Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision: comments v4 - Changes: - all: https://git.openjdk.java.net/jdk/pull/411/files - new: https://git.openjdk.java.net

Re: RFR: 8253821: Improve ByteBuffer performance with GCM [v6]

2020-12-01 Thread Anthony Scarpino
On Thu, 26 Nov 2020 02:18:00 GMT, Anthony Scarpino wrote: >> The latest update should address all outstanding comments. The biggest >> change was to the test, which had major reorganization and created tests >> that increments data sizes for update and doFinal ops byte-by-byte to check >> fo