Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-22 Thread Valerie Peng
On Thu, 15 Apr 2021 10:27:25 GMT, Sibabrata Sahoo wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed an tagLen issue, no key+iv reuse check for decryption, and add >> regression test for ChaCha20 SKF. > > test/

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-22 Thread Valerie Peng
On Thu, 15 Apr 2021 14:25:13 GMT, Jamil Nimeh wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed an tagLen issue, no key+iv reuse check for decryption, and add >> regression test for ChaCha20 SKF. > > src/jdk.c

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Jamil Nimeh
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Jamil Nimeh
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-15 Thread Sibabrata Sahoo
On Wed, 14 Apr 2021 03:58:33 GMT, Valerie Peng wrote: >> Could someone (perhaps Jamil?) please help review this change? This enhances >> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation >> support. Majority of the regression tests are adapted from the existing ones

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-13 Thread Valerie Peng
> Could someone (perhaps Jamil?) please help review this change? This enhances > SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation > support. Majority of the regression tests are adapted from the existing ones > for SunJCE provider's ChaCha20-Poly1305 cipher impl. When