Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-22 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 20:05:19 GMT, Valerie Peng wrote: >> Thank you, @valeriepeng. I am not sure what is the review policy for this >> code, should I wait for another reviewer? > > One reviewer is good enough. You can go ahead and integrate. Thanks~ Got it, thanks! - PR: https://gi

Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-20 Thread Valerie Peng
On Fri, 20 Nov 2020 06:46:09 GMT, Aleksey Shipilev wrote: >> Changes look good. > > Thank you, @valeriepeng. I am not sure what is the review policy for this > code, should I wait for another reviewer? One reviewer is good enough. You can go ahead and integrate. Thanks~ - PR: http

Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-19 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 00:14:55 GMT, Valerie Peng wrote: >> Current `sun/security/provider/SHA2` implementation is written with lots of >> small method invocations on the fastpath in `implCompress0`. Normally it >> does not matter much, because compilers are able to inline through it, and >> then

Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-19 Thread Valerie Peng
On Wed, 18 Nov 2020 08:29:49 GMT, Aleksey Shipilev wrote: > Current `sun/security/provider/SHA2` implementation is written with lots of > small method invocations on the fastpath in `implCompress0`. Normally it does > not matter much, because compilers are able to inline through it, and then >

Re: RFR: 8256523: Streamline Java SHA2 implementation

2020-11-18 Thread Valerie Peng
On Wed, 18 Nov 2020 08:29:49 GMT, Aleksey Shipilev wrote: > Current `sun/security/provider/SHA2` implementation is written with lots of > small method invocations on the fastpath in `implCompress0`. Normally it does > not matter much, because compilers are able to inline through it, and then >

RFR: 8256523: Streamline Java SHA2 implementation

2020-11-18 Thread Aleksey Shipilev
Current `sun/security/provider/SHA2` implementation is written with lots of small method invocations on the fastpath in `implCompress0`. Normally it does not matter much, because compilers are able to inline through it, and then some compilers even intrinsify the entire `implCompress0`. But it