On Thu, 8 Apr 2021 17:18:50 GMT, Jamil Nimeh wrote:
>> I don't want to go on reading the following bytes to find out what the
>> intended tag number is, because that somehow shows I do understand the
>> encoding _a lot_ but still don't want to support it (well, actually I only
>> understand
On Thu, 8 Apr 2021 16:59:54 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/DerValue.java line 225:
>>
>>> 223: DerValue(byte tag, byte[] buffer, int start, int end, boolean
>>> allowBER) {
>>> 224: if ((tag & 0x1f) == 0x1f) {
>>> 225: throw new
On Thu, 8 Apr 2021 17:10:13 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/DerValue.java line 322:
>>
>>> 320: tag = buf[pos++];
>>> 321: if ((tag & 0x1f) == 0x1f) {
>>> 322: throw new IOException("Tag number over 30 is not
>>> supported");
On Thu, 8 Apr 2021 16:58:24 GMT, Jamil Nimeh wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update exception wordings
>
> src/java.base/share/classes/sun/security/util/DerValue.java line 322:
>
>> 320:
On Thu, 8 Apr 2021 15:53:10 GMT, Xue-Lei Andrew Fan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update exception wordings
>
> src/java.base/share/classes/sun/security/util/DerValue.java line 225:
>
>> 223:
On Thu, 8 Apr 2021 13:57:37 GMT, Weijun Wang wrote:
>> This code change does not intend to support multiple byte tags. Instead, it
>> aims to fail more gracefully when such a tag is encountered. For `DerValue`
>> constructors from an encoding (type I), an `IOException` will be thrown
>> since
On Thu, 8 Apr 2021 13:57:37 GMT, Weijun Wang wrote:
>> This code change does not intend to support multiple byte tags. Instead, it
>> aims to fail more gracefully when such a tag is encountered. For `DerValue`
>> constructors from an encoding (type I), an `IOException` will be thrown
>> since
> This code change does not intend to support multiple byte tags. Instead, it
> aims to fail more gracefully when such a tag is encountered. For `DerValue`
> constructors from an encoding (type I), an `IOException` will be thrown since
> it's already in the throws clause. For constructors from
