On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do not call internal method
Marked as reviewed
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do not call internal method
Marked as reviewed
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do not call internal method
Marked as reviewed
> I'd like to move this tool to test/lib inside a proper named package.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
do not call internal method
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3496/files
-
On Wed, 14 Apr 2021 20:48:07 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move to process and a test for itself
New commit
> I'd like to move this tool to test/lib inside a proper named package.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
move to process and a test for itself
-
Changes:
- all:
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Looks good to me.
-
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3496
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
I think is fine to move it first and refactor it separately; that's a bigger
job.
If its fit for the purpose, the overlap is fine between tools.
-
PR:
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Well, we can certainly rename it. It's only used by several tests. Maybe
`ChildProcess`?
And we can certainly move it to a different package. I know it has some
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Good idea. Is there a more evocative class name than Proc?
It looks similar to jdk.test.lib.process.ProcessTools.
Would it fit in the jdk.test.lib.process package? It
I'd like to move this tool to test/lib inside a proper named package.
-
Commit messages:
- 8265227: Move Proc.java from security/testlibrary to test/lib
Changes: https://git.openjdk.java.net/jdk/pull/3496/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3496=00
Issue:
11 matches
Mail list logo