Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-15 Thread Roger Riggs
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > do not call internal method Marked as reviewed

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-15 Thread Sibabrata Sahoo
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > do not call internal method Marked as reviewed

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-14 Thread Rajan Halade
On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > do not call internal method Marked as reviewed

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v3]

2021-04-14 Thread Weijun Wang
> I'd like to move this tool to test/lib inside a proper named package. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: do not call internal method - Changes: - all: https://git.openjdk.java.net/jdk/pull/3496/files -

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v2]

2021-04-14 Thread Weijun Wang
On Wed, 14 Apr 2021 20:48:07 GMT, Weijun Wang wrote: >> I'd like to move this tool to test/lib inside a proper named package. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > move to process and a test for itself New commit

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib [v2]

2021-04-14 Thread Weijun Wang
> I'd like to move this tool to test/lib inside a proper named package. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: move to process and a test for itself - Changes: - all:

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-14 Thread Xue-Lei Andrew Fan
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote: > I'd like to move this tool to test/lib inside a proper named package. Looks good to me. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3496

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-14 Thread Roger Riggs
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote: > I'd like to move this tool to test/lib inside a proper named package. I think is fine to move it first and refactor it separately; that's a bigger job. If its fit for the purpose, the overlap is fine between tools. - PR:

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-14 Thread Weijun Wang
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote: > I'd like to move this tool to test/lib inside a proper named package. Well, we can certainly rename it. It's only used by several tests. Maybe `ChildProcess`? And we can certainly move it to a different package. I know it has some

Re: RFR: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-14 Thread Roger Riggs
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote: > I'd like to move this tool to test/lib inside a proper named package. Good idea. Is there a more evocative class name than Proc? It looks similar to jdk.test.lib.process.ProcessTools. Would it fit in the jdk.test.lib.process package? It

RFR: 8265227: Move Proc.java from security/testlibrary to test/lib

2021-04-14 Thread Weijun Wang
I'd like to move this tool to test/lib inside a proper named package. - Commit messages: - 8265227: Move Proc.java from security/testlibrary to test/lib Changes: https://git.openjdk.java.net/jdk/pull/3496/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3496=00 Issue: