Re: RFR: 8267587: Update java.util to use enhanced switch [v7]

2021-05-30 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

2021-05-30 Thread Tagir F . Valeev
On Thu, 27 May 2021 13:47:16 GMT, Daniel Fuchs wrote: >> Tagir F. Valeev has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src/java.base/share/classes/java/ut

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

2021-05-27 Thread Daniel Fuchs
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Tagir F . Valeev
On Tue, 25 May 2021 16:52:06 GMT, Brian Goetz wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/JapaneseImperialCalendar.java line 1371: > >> 1369

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

2021-05-25 Thread Tagir F . Valeev
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

2021-05-25 Thread Iris Clark
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v6]

2021-05-25 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Tagir F . Valeev
On Tue, 25 May 2021 15:51:38 GMT, Chris Hegarty wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/Calendar.java line 1507: > >> 1505:

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Tagir F . Valeev
On Tue, 25 May 2021 16:47:15 GMT, Brian Goetz wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More vertical alignment > > src/java.base/share/classes/java/util/Calendar.java line 1507: > >> 1505:

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Brian Goetz
On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Brian Goetz
On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Chris Hegarty
On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v5]

2021-05-25 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch [v4]

2021-05-25 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

2021-05-25 Thread Tagir F . Valeev
On Tue, 25 May 2021 10:31:33 GMT, Patrick Concannon wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Indent some lines to make GitHub diff happier > > src/java.base/share/classes/java/util/GregorianCalendar.java

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

2021-05-25 Thread Patrick Concannon
On Tue, 25 May 2021 06:01:49 GMT, Tagir F. Valeev wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expres

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

2021-05-24 Thread Tagir F . Valeev
On Tue, 25 May 2021 03:48:41 GMT, Tagir F. Valeev wrote: >> src/java.base/share/classes/java/util/regex/CharPredicates.java line 217: >> >>> 215: case "WORD" -> WORD(); >>> 216: default -> null; >>> 217: }; >> >> This file has lots of changes which are difficult

Re: RFR: 8267587: Update java.util to use enhanced switch [v3]

2021-05-24 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch [v2]

2021-05-24 Thread Tagir F . Valeev
> Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression branches, etc. > > I also noticed that there are some swi

Re: RFR: 8267587: Update java.util to use enhanced switch

2021-05-24 Thread Tagir F . Valeev
On Mon, 24 May 2021 13:46:58 GMT, Daniel Fuchs wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expressio

Re: RFR: 8267587: Update java.util to use enhanced switch

2021-05-24 Thread Tagir F . Valeev
On Mon, 24 May 2021 13:44:36 GMT, Daniel Fuchs wrote: >> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expressio

Re: RFR: 8267587: Update java.util to use enhanced switch

2021-05-24 Thread Daniel Fuchs
On Mon, 24 May 2021 04:20:23 GMT, Tagir F. Valeev wrote: > Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression

RFR: 8267587: Update java.util to use enhanced switch

2021-05-23 Thread Tagir F . Valeev
Inspired by PR#4088. Most of the changes are done automatically using IntelliJ IDEA refactoring. Some manual adjustments are also performed, including indentations, moving comments, extracting common cast out of switch expression branches, etc. I also noticed that there are some switches having

Re: RFR: 8267587: Update java.util to use enhanced switch

2021-05-23 Thread Tagir F . Valeev
On Mon, 24 May 2021 04:20:23 GMT, Tagir F. Valeev wrote: > Inspired by PR#4088. Most of the changes are done automatically using > IntelliJ IDEA refactoring. Some manual adjustments are also performed, > including indentations, moving comments, extracting common cast out of switch > expression