Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-18 Thread Hai-May Chao
> It'd be useful to have a -version option for keytool and jarsigner. Many > other JDK tools already have a -version option. This is to add -version > option to keytool and jarsigner like jar command does. > > CSR review: > https://bugs.openjdk.java.net/browse/JDK-8275174 Hai-May Chao has updat

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-19 Thread Weijun Wang
On Tue, 19 Oct 2021 06:26:17 GMT, Hai-May Chao wrote: >> It'd be useful to have a -version option for keytool and jarsigner. Many >> other JDK tools already have a -version option. This is to add -version >> option to keytool and jarsigner like jar command does. >> >> CSR review: >> https://bu

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-19 Thread Weijun Wang
On Tue, 19 Oct 2021 06:26:17 GMT, Hai-May Chao wrote: >> It'd be useful to have a -version option for keytool and jarsigner. Many >> other JDK tools already have a -version option. This is to add -version >> option to keytool and jarsigner like jar command does. >> >> CSR review: >> https://bu

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-19 Thread Hai-May Chao
On Tue, 19 Oct 2021 13:10:15 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated comment in test > > Approved the PR. Thanks. I have a small comment on the CSR. @wangweij Thanks for reviewing

Re: RFR: 8272163: Add -version option to keytool and jarsigner [v4]

2021-10-19 Thread Hai-May Chao
On Tue, 19 Oct 2021 13:10:15 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated comment in test > > Approved the PR. Thanks. I have a small comment on the CSR. @wangweij Updated the CSR with