On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Please re-review this
On Wed, 22 Sep 2021 10:24:12 GMT, Pavel Rappo wrote:
>> Note that we don't throw the "wrapped exception" we throw the exception that
>> wraps it. The "wrapped exception" is the original cause. The wording as
>> presented now is correct in that regard. You could also say "Throwing a
>> wrapper
On Tue, 21 Sep 2021 22:00:29 GMT, David Holmes wrote:
>> Instead of "common case where a wrapped exception is thrown from same
>> method" could one write "common case where an enclosing exception is thrown
>> from the same method"?
>
> Note that we don't throw the "wrapped exception" we throw t
On Tue, 21 Sep 2021 17:52:31 GMT, Brian Burkhalter wrote:
>> We can either revert this part of the change or rephrase it. Mind you,
>> rephrasing might prove tricky because of non-local changes it might
>> introduce. There's one more occurrence of "wrapped exception" in this file:
>> https://g
On Tue, 21 Sep 2021 17:39:41 GMT, Pavel Rappo wrote:
>> Would "wrappER" be better?
>
> We can either revert this part of the change or rephrase it. Mind you,
> rephrasing might prove tricky because of non-local changes it might
> introduce. There's one more occurrence of "wrapped exception" in
On Tue, 21 Sep 2021 17:14:31 GMT, Pavel Rappo wrote:
>> Subjectively, "wrapping exception" would seem to be an exception in the
>> process of wrapping something.
>
> Would "wrappER" be better?
We can either revert this part of the change or rephrase it. Mind you,
rephrasing might prove tricky
On Tue, 21 Sep 2021 17:10:02 GMT, Brian Burkhalter wrote:
>> If we have two exceptions A and B, such that B is the cause of A, then A is
>> the wrapping exception (the one that wraps or the wrapper) and B is the
>> wrapped exception (the one that is being wrapped or the wrappee).
>>
>> I notic
On Tue, 21 Sep 2021 16:56:03 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/lang/Throwable.java line 68:
>>
>>> 66: * Further, doing so would tie the API of the upper layer to the
>>> details of
>>> 67: * its implementation, assuming the lower layer's exception was a
>>> chec
On Tue, 21 Sep 2021 17:07:45 GMT, Pavel Rappo wrote:
>> It does seem a bit strange to say "Throwing a wrapping"
>
> If we have two exceptions A and B, such that B is the cause of A, then A is
> the wrapping exception (the one that wraps or the wrapper) and B is the
> wrapped exception (the
On Tue, 21 Sep 2021 16:48:53 GMT, Brian Burkhalter wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak wording for Throwable constructor parameters
>
> src/java.base/share/classes/java/lang/Throwable.java line 68:
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Overall looks like a g
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
src/java.base/share/cl
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Marked as reviewed by
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Marked as reviewed by
> 8274075: Fix miscellaneous typos in java.base
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Tweak wording for Throwable constructor parameters
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5610/files
- n
15 matches
Mail list logo
