Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-02 Thread Valerie Peng
On Thu, 2 Dec 2021 01:42:58 GMT, Weijun Wang wrote: > Not a PKCS11 expert, but does a "digest-specific PSS signature mechanism" > needs `setParameter` anymore? Or, must it be the same as the existing > parameters dictated by the specified digest? Previously when PSS support is added, the NSS l

Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-02 Thread Daniel D . Daugherty
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-02 Thread Daniel D . Daugherty
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-01 Thread Weijun Wang
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-01 Thread Valerie Peng
Can someone help reviewing this trivial one-line fix? The assert check in CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific PSS signature mechanisms are supported by the underlying PKCS#11 library. The fix is to remove this assert check. No new regression test added with