Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]

2022-01-12 Thread Xue-Lei Andrew Fan
On Wed, 12 Jan 2022 07:29:04 GMT, John Jiang wrote: >> In class `sun.security.ec.ECDHKeyAgreement`, the last `mod()` in the below >> line looks redundant, >> >> BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); >> >> I think this tiny change just be a code cleanup, so no test for it

Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]

2022-01-12 Thread Weijun Wang
On Wed, 12 Jan 2022 07:29:04 GMT, John Jiang wrote: >> In class `sun.security.ec.ECDHKeyAgreement`, the last `mod()` in the below >> line looks redundant, >> >> BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); >> >> I think this tiny change just be a code cleanup, so no test for it

Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]

2022-01-11 Thread John Jiang
> In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the > below line looks redundant, > > BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); John Jiang has updated the pull request incrementally with one additional commit since the last revision: update copyright

RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement

2022-01-11 Thread John Jiang
In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the below line looks redundant, BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); - Commit messages: - 8279903: Redundant modulo operation in ECDHKeyAgreement Changes: https://git.openjdk.java.net/jdk/