On Sun, 24 Apr 2022 15:54:15 GMT, Xue-Lei Andrew Fan wrote:
> I like this explanation more. I have no more comment about the patch. Please
> add a noreg label in JBS.
`noreg-sqe` seems appropriate.
-
PR: https://git.openjdk.java.net/jdk/pull/8372
On Mon, 25 Apr 2022 05:22:33 GMT, xueleifan(XueleiFan)
wrote:
> Hi Thomas,
>
> Did you have a reproducing code that I would play with?
>
> Thanks,
> Xuelei
[mlbridge](https://github.com/apps/mlbridge) copied the comment, but it is not
expected to post here. This PR is not related to JDK-8221
On Fri, 22 Apr 2022 21:04:58 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I'd like a code review of this change to EdDSA. ed25519 and ed448 internally
> was trimming extra zeros off the end of the signature before processing. This
> can result in some verify testing failures which are strict about
On Fri, 22 Apr 2022 21:04:58 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I'd like a code review of this change to EdDSA. ed25519 and ed448 internally
> was trimming extra zeros off the end of the signature before processing. This
> can result in some verify testing failures which are strict about
On Sun, 24 Apr 2022 15:34:23 GMT, Anthony Scarpino
wrote:
> > Did you want to correct the verify testing so that it could
> > accept trimmed signature? Or do not trimming the extra zeros
> > of the signature any longer? I did not get the point from the
> > patch.
>
> The test is correct. Perh
On Sat, 23 Apr 2022 14:39:50 GMT, Xue-Lei Andrew Fan wrote:
> Did you want to correct the verify testing so that it could
> accept trimmed signature? Or do not trimming the extra zeros
> of the signature any longer? I did not get the point from the
> patch.
The test is correct.
Perhaps a clea
On Fri, 22 Apr 2022 21:04:58 GMT, Anthony Scarpino
wrote:
> ed25519 and ed448 internally was trimming extra zeros off the end of the
> signature before processing. This can result in some verify testing failures
> which are strict about the signature length passed into the operation.
>
Did y
Hi,
I'd like a code review of this change to EdDSA. ed25519 and ed448 internally
was trimming extra zeros off the end of the signature before processing. This
can result in some verify testing failures which are strict about the signature
length passed into the operation.
thanks
Tony
--
