Re: RFR: JDK-8049244: XML Signature performance issue caused by unbuffered signature data

2014-07-08 Thread Xuelei Fan
Looks fine to me. The old code looks a little bit hard to understand to me. Xuelei On 7/8/2014 9:15 PM, Sean Mullan wrote: > Please review my fix for JDK-8049244: > > http://cr.openjdk.java.net/~mullan/webrevs/8049244/webrev.00/ > > This is a direct port of the corresponding fix from Apach

RFR: JDK-8049244: XML Signature performance issue caused by unbuffered signature data

2014-07-08 Thread Sean Mullan
Please review my fix for JDK-8049244: http://cr.openjdk.java.net/~mullan/webrevs/8049244/webrev.00/ This is a direct port of the corresponding fix from Apache Santuario. No regression test since this is a performance related fix. However, the customer that reported this to the Apache Santu