Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

2016-12-12 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 12/12/2016 2:29 AM, John Jiang wrote: Hi Xuelei, Thanks for your comments. Please review this new webrev: http://cr.openjdk.java.net/~jjiang/8171043/webrev.01/ Best regards, John Jiang On 2016/12/12 13:07, Xuelei Fan wrote: Hi John, It's a good catch of

Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

2016-12-12 Thread John Jiang
Hi Xuelei, Thanks for your comments. Please review this new webrev: http://cr.openjdk.java.net/~jjiang/8171043/webrev.01/ Best regards, John Jiang On 2016/12/12 13:07, Xuelei Fan wrote: Hi John, It's a good catch of the problem. Looks like the server side should read the HTTP request at f

Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

2016-12-11 Thread Felix Yang
+1, it is a good habit to read off the data before closing the connection. Otherwise this may lead to "connection reset " exception sometimes. -Felix On 2016/12/12 13:07, Xuelei Fan wrote: Hi John, It's a good catch of the problem. Looks like the server side should read the HTTP request at

Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

2016-12-11 Thread Xuelei Fan
Hi John, It's a good catch of the problem. Looks like the server side should read the HTTP request at first, and then write the HTTP response. That's the server call: InputStream sslIS = socket.getInputStream(); sslIS.read(); and then write the "HTTP/1.1, ...". Thanks, Xuelei On 1

RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

2016-12-11 Thread John Jiang
Hi, Please review this patch for test sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java Before the client get the response, the server may close. Webrev: http://cr.openjdk.java.net/~jjiang/8171043/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8171043 Best regards, Joh