RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-07 Thread Sean Mullan
Please review this change to deprecate the following APIs: java.security.cert.X509Certificate.getIssuerDN() java.security.cert.X509Certificate.getSubjectDN() java.security.cert.X509CRL.getIssuerDN() java.security.cert.X509CertSelector.setIssuer(String) java.security.cert.X509CertSelector.setSubje

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-21 Thread Sean Mullan
Ping ... On 8/7/20 10:01 AM, Sean Mullan wrote: Please review this change to deprecate the following APIs: java.security.cert.X509Certificate.getIssuerDN() java.security.cert.X509Certificate.getSubjectDN() java.security.cert.X509CRL.getIssuerDN() java.security.cert.X509CertSelector.setIssuer(St

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-21 Thread Xuelei Fan
Looks fine to me. Just a trivial format comment. Some use link for "RFC 2253", some do not. It's OK. And it's good as well if you want to use a uniform style. Xuelei On 8/21/2020 9:24 AM, Sean Mullan wrote: Ping ... On 8/7/20 10:01 AM, Sean Mullan wrote: Please review this change to depr

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-21 Thread Valerie Peng
Is it intentional to use toString() in src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java? Normally, toString() is kind of loose, not as strict as getName(). Valerie On 8/21/2020 11:01 AM, Xuelei Fan wrote: Looks fine to me. Just a trivial format comment.  Some use link for

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-26 Thread Sean Mullan
On 8/21/20 2:01 PM, Xuelei Fan wrote: Looks fine to me. Just a trivial format comment.  Some use link for "RFC 2253", some do not. It's OK.  And it's good as well if you want to use a uniform style. Good point. Several methods in X509CertSelector and X509CRLSelector reference RFC 2253 severa

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-26 Thread Sean Mullan
On 8/21/20 2:14 PM, Valerie Peng wrote: Is it intentional to use toString() in src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java? Normally, toString() is kind of loose, not as strict as getName(). In this case I think toString() is ok, since jarsigner is printing informatio

Re: RFR (16): 8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects

2020-08-27 Thread Valerie Peng
Ok, thanks for the reply. Valerie On 8/26/2020 5:02 AM, Sean Mullan wrote: On 8/21/20 2:14 PM, Valerie Peng wrote: Is it intentional to use toString() in src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java? Normally, toString() is kind of loose, not as strict as getName().