Re: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-19 Thread Xuelei Fan
Hi Christoph, Thank you for taking care of this issue. Some minor comments: SSLSocketImpl.java -- 1012if (buffer != null && (buffer.limit() < inputRecord.bytesInCompletePacket(sockInput))) 1013 return 0; 1. It would be nice to keep the line less than 80 characters. 2

RE: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-19 Thread Langer, Christoph
, 18. März 2016 03:52 > To: security-dev@openjdk.java.net > Subject: Re: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord > buffer overflow > > Hi Christoph, > > Thank you for taking care of this issue. Some minor comments: > > SSLSocketImpl.j

RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-19 Thread Langer, Christoph
Hi, I think I've found a way to fix the issue which looks quite reasonable to me. Would you please comment/review it? I've also included a test to reproduce the issue. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8149169.1/ Bug: https://bugs.openjdk.java.net/browse/JDK-8149169 Th

Re: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-19 Thread Xuelei Fan
9169.2/ > > >> -Original Message- >> From: Langer, Christoph >> Sent: Freitag, 18. März 2016 10:29 >> To: 'Xuelei Fan' >> Cc: security-dev@openjdk.java.net >> Subject: RE: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord >> buffer over

RE: RFR (S): JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-18 Thread Langer, Christoph
> > -Original Message- > > From: security-dev [mailto:security-dev-boun...@openjdk.java.net] On > Behalf > > Of Xuelei Fan > > Sent: Freitag, 18. März 2016 03:52 > > To: security-dev@openjdk.java.net > > Subject: Re: RFR (S): JDK-8149169 - SSLSocketInp