Re: RFR [12]: 8210448: Copy Java XML Digital Signature API Specification into java.xml.crypto javadocs

2018-10-16 Thread Weijun Wang
> On Oct 16, 2018, at 11:53 PM, Sean Mullan wrote: > > Can you also review the CSR and add your name as reviewer? Added. Do you want to add a link to 'the normative sections of the "Java XML Digital Signature API Specification"' in the CSR? Thanks Max

Re: RFR [12]: 8210448: Copy Java XML Digital Signature API Specification into java.xml.crypto javadocs

2018-10-16 Thread Sean Mullan
On 10/16/18 1:37 AM, Weijun Wang wrote: The links from source to "DOM Mechanism Requirements" use "package-summary.html#dom_reqs", but the id in dsig/package-info.java is "dom_req". Good catch! In the sections you copied from the JSR 105 spec, some class/method names have links to the API s

Re: RFR [12]: 8210448: Copy Java XML Digital Signature API Specification into java.xml.crypto javadocs

2018-10-15 Thread Weijun Wang
The links from source to "DOM Mechanism Requirements" use "package-summary.html#dom_reqs", but the id in dsig/package-info.java is "dom_req". In the sections you copied from the JSR 105 spec, some class/method names have links to the API spec pages, some only formatted as fixed-width texts (eve

RFR [12]: 8210448: Copy Java XML Digital Signature API Specification into java.xml.crypto javadocs

2018-10-15 Thread Sean Mullan
Please review this change to copy the normative parts of the Java XML Digital Signature API Specification into the java.xml.crypto module javadocs and update relevant links in the javadocs. The Java XML Digital Signature API Specification was published as part of JSR 105 and was previously incl