Re: RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-09 Thread Sean Mullan
On 07/09/2014 12:31 AM, Wang Weijun wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/8049480/webrev.01/. Looks good to me. --Sean

Re: RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-08 Thread Wang Weijun
On Jul 8, 2014, at 23:15, Xuelei Fan wrote: > Looks fine to me. > > It would be nice to extend AlgorithmId.getStandardDigestName() to > AlgorithmId.getStandardName() in the future. The JDK8 version of fix for 7180907 already had AlgorithmId.getName() returning the standard one. --Max > > X

Re: RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-08 Thread Wang Weijun
Webrev updated at phttp://cr.openjdk.java.net/~weijun/8049480/webrev.01/. Thanks Max On Jul 9, 2014, at 0:45, Sean Mullan wrote: > On 07/08/2014 10:37 AM, Wang Weijun wrote: >> Please review the jdk7u-only code change at >> >> http://cr.openjdk.java.net/~weijun/8049480/webrev.00/ >> >> The re

Re: RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-08 Thread Sean Mullan
On 07/08/2014 10:37 AM, Wang Weijun wrote: Please review the jdk7u-only code change at http://cr.openjdk.java.net/~weijun/8049480/webrev.00/ The reason is that the jdk7u version [1] of fix for JDK-8049480 is just a hack and not as powerful as its jdk8 sibling [2] and now I'll have to apply

Re: RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-08 Thread Xuelei Fan
Looks fine to me. It would be nice to extend AlgorithmId.getStandardDigestName() to AlgorithmId.getStandardName() in the future. Xuelei On 7/8/2014 10:37 PM, Wang Weijun wrote: > Please review the jdk7u-only code change at > > http://cr.openjdk.java.net/~weijun/8049480/webrev.00/ > > The rea

RFR 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9

2014-07-08 Thread Wang Weijun
Please review the jdk7u-only code change at http://cr.openjdk.java.net/~weijun/8049480/webrev.00/ The reason is that the jdk7u version [1] of fix for JDK-8049480 is just a hack and not as powerful as its jdk8 sibling [2] and now I'll have to apply the jdk7u jar signature "hack" to timestamp s