Re: RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-30 Thread Sean Mullan
On 5/29/18 8:18 PM, Weijun Wang wrote: CSR approved. Please review the code change and release note. Looks good. --Sean Thanks Max On May 26, 2018, at 6:06 PM, Weijun Wang wrote: Please also review the release note at https://bugs.openjdk.java.net/browse/JDK-8203846. Thanks. On May

Re: RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-29 Thread Weijun Wang
CSR approved. Please review the code change and release note. Thanks Max > On May 26, 2018, at 6:06 PM, Weijun Wang wrote: > > Please also review the release note at > https://bugs.openjdk.java.net/browse/JDK-8203846. > > Thanks. > >> On May 25, 2018, at 8:27 AM, Weijun Wang wrote: >> >> C

Re: RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-26 Thread Weijun Wang
Please also review the release note at https://bugs.openjdk.java.net/browse/JDK-8203846. Thanks. > On May 25, 2018, at 8:27 AM, Weijun Wang wrote: > > CSR and webrev updated. > > webrev: http://cr.openjdk.java.net/~weijun/8072996/webrev.01/ > CSR: https://bugs.openjdk.java.net/browse/J

Re: RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-24 Thread Weijun Wang
CSR and webrev updated. webrev: http://cr.openjdk.java.net/~weijun/8072996/webrev.01/ CSR: https://bugs.openjdk.java.net/browse/JDK-8202953 Thanks Max > On May 25, 2018, at 1:06 AM, Sean Mullan wrote: > > For the new paragraph in GSSContext, I think you should quote RFC 8353 since >

Re: RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-24 Thread Sean Mullan
For the new paragraph in GSSContext, I think you should quote RFC 8353 since you are taking the wording from that. You should also say "Java SE 11" instead of "JDK 11". So here is a possible re-wording: The stream-based methods of {@code GSSContext} have been deprecated in Java SE 11. These me

RFR 8072996: Deprecate stream-based GSSContext methods

2018-05-23 Thread Weijun Wang
RFC 8353 has removed stream-based GSSContext methods [1]. Therefore we deprecate them in JDK. Please take a review at webrev: http://cr.openjdk.java.net/~weijun/8072996/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8202953 Thanks Max [1] https://tools.ietf.org/html/rfc8353#s