Re: RFR 8074838: Resolve disabled warnings for libj2pkcs11

2016-08-26 Thread Erik Joelsson
Looks ok to me. /Erik On 2016-08-25 23:20, Anthony Scarpino wrote: Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the pkcs11 wrapper library. http://cr.openjdk.java.net/~ascarpino/8074838/webrev/ thanks

Re: RFR 8074838: Resolve disabled warnings for libj2pkcs11

2016-08-25 Thread Bradford Wetmore
Looks ok to me... I had to look at the C declaration one twice. Too much Java, not enough C lately. Brad On 8/25/2016 2:20 PM, Anthony Scarpino wrote: Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the

RFR 8074838: Resolve disabled warnings for libj2pkcs11

2016-08-25 Thread Anthony Scarpino
Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the pkcs11 wrapper library. http://cr.openjdk.java.net/~ascarpino/8074838/webrev/ thanks Tony