> On Sep 22, 2018, at 2:49 AM, Sean Mullan wrote:
>
> Still reviewing but here are some initial comments.
>
> It seems this is more than a fix for JDK-8076190. It also adds configuration
> properties for the PKCS12 algorithms. I think you should expand the
> scope/description of the issue t
Still reviewing but here are some initial comments.
It seems this is more than a fix for JDK-8076190. It also adds
configuration properties for the PKCS12 algorithms. I think you should
expand the scope/description of the issue to include that.
* HmacPKCS12PBECore.java
The class description
Webrev updated at
http://cr.openjdk.java.net/~weijun/8076190/webrev.02
The only change is in keytool/Main and the test. keytool will not prompt for
store password if it detects a password-less keystore.
This is 3) below.
Thanks
Max
> On Jul 24, 2018, at 6:49 PM, Weijun Wang wrote:
>
> Pl
Please review the code change and CSR at
webrev: http://cr.openjdk.java.net/~weijun/8076190/webrev.01/
CSR: https://bugs.openjdk.java.net/browse/JDK-8202590
The bug is at
https://bugs.openjdk.java.net/browse/JDK-8076190
This is the 1st part of the process to make cacerts using pkcs12:
