Re: RFR 8133910: Some sun/security/tools tests failed.

2016-08-10 Thread Xuelei Fan
Looks fine. Xuelei On 8/11/2016 11:31 AM, Weijun Wang wrote: > Ping again. Thanks. --Max > > On 8/9/2016 15:37, Wang Weijun wrote: >> Please review the fix at >> >> http://cr.openjdk.java.net/~weijun/8133910/webrev.00/ >> >> Basically, "-J-Duser.language=en -J-Duser.country=US" is added to >>

Re: RFR 8133910: Some sun/security/tools tests failed.

2016-08-10 Thread Weijun Wang
Ping again. Thanks. --Max On 8/9/2016 15:37, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8133910/webrev.00/ Basically, "-J-Duser.language=en -J-Duser.country=US" is added to keytool and jarsigner calls wherever output needs to be compared to some English t

Re: RFR 8133910: Some sun/security/tools tests failed.

2016-08-09 Thread Artem Smotrakov
Hi Max, The update looks good to me. Artem On 08/09/2016 08:39 AM, Weijun Wang wrote: I was wrong. The test were written by Artem. --Max On 8/9/2016 15:37, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8133910/webrev.00/ Basically, "-J-Duser.language=en

Re: RFR 8133910: Some sun/security/tools tests failed.

2016-08-09 Thread Weijun Wang
I was wrong. The test were written by Artem. --Max On 8/9/2016 15:37, Wang Weijun wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8133910/webrev.00/ Basically, "-J-Duser.language=en -J-Duser.country=US" is added to keytool and jarsigner calls wherever output needs to be

RFR 8133910: Some sun/security/tools tests failed.

2016-08-09 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8133910/webrev.00/ Basically, "-J-Duser.language=en -J-Duser.country=US" is added to keytool and jarsigner calls wherever output needs to be compared to some English text. *Siba*: I modified quite some tests by you. Please confirm it