Re: RFR 8141457: keytool default cert fingerprint algorithm should be SHA-256

2015-12-01 Thread Sean Mullan
On 11/25/2015 09:39 PM, Wang Weijun wrote: Updated at http://cr.openjdk.java.net/~weijun/8141457/webrev.01/. I was lazy last time. Looks good. --Sean --Max On Nov 24, 2015, at 8:15 PM, Sean Mullan wrote: Looks good - although you could replace the MD5 fingerprints with the SHA256 fing

Re: RFR 8141457: keytool default cert fingerprint algorithm should be SHA-256

2015-11-26 Thread Wang Weijun
Updated at http://cr.openjdk.java.net/~weijun/8141457/webrev.01/. I was lazy last time. --Max > On Nov 24, 2015, at 8:15 PM, Sean Mullan wrote: > > Looks good - although you could replace the MD5 fingerprints with the SHA256 > fingerprints in the test files for some additional testing. > > -

Re: RFR 8141457: keytool default cert fingerprint algorithm should be SHA-256

2015-11-24 Thread Sean Mullan
Looks good - although you could replace the MD5 fingerprints with the SHA256 fingerprints in the test files for some additional testing. --Sean On 11/23/2015 08:00 PM, Wang Weijun wrote: Hi All Please review a code change at http://cr.openjdk.java.net/~weijun/8141457/webrev.00/ SHA-256

RFR 8141457: keytool default cert fingerprint algorithm should be SHA-256

2015-11-23 Thread Wang Weijun
Hi All Please review a code change at http://cr.openjdk.java.net/~weijun/8141457/webrev.00/ SHA-256 is now the default fingerprint algorithm, and MD5 is removed in the full list. No new regression test, I consider the change trivial. If you think one is better, I'll add it. Thanks Max