Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Thanks, I have no more comments. - Rajan On 5/26/2016 16:58, Amanda Jiang wrote: Hi Rajan, Thanks for your suggestions, I have updated tests with your comments. For TestSampleLength.java, please see my reply inline. webrev: http://cr.openjdk.java.net/~amjiang/8156059/webrev.03/ Thanks, Ama

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi Rajan, Thanks for your suggestions, I have updated tests with your comments. For TestSampleLength.java, please see my reply inline. webrev: http://cr.openjdk.java.net/~amjiang/8156059/webrev.03/ Thanks, Amanda On 16/5/25 下午12:31, Rajan Halade wrote: Hi Amanda, Thanks for the update. Few

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi Amanda, Thanks for the update. Few more comments after review: - TestSameLength.java: line 93-103, check here should use provider used with test instance of MessageDigest, call md.getProvider(). You will need to reorganize test code for this. Security.getProvider() returns provider install

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi Valerie , Rajan, Thanks for reviewing the webrev. I have updaed UnsupportedProvider.java to check NSAE for SUN and OracleUcrypto providers. Other tests has been updated by Rajan's comments as well. Please check the latest webrev and let me know if there are any other problems. http://

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

True, I think the UnsupportedProvider.java should assume SUN provider to support SHA-3 and not allow NSAE. OracleUcrypto provider only supports SHA-3 on Solaris 12 or later, so what you have is fine. As for other tests, as long as SHA-3 algos are covered, it's up to you to make the enhanceme

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hmm, please ignore this. The comment is for another review... Valerie On 5/19/2016 2:49 PM, Valerie Peng wrote: Hi Amanda, Tests look fine. Thanks for covering all these test vectors. One thing that I am not sure is the usage of @library, see below. Is this really used? I see the same in in b

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi Amanda, I have following comments: - UnsupportedProvider.java line 55: this assumes that it is okay to have NoSuchAlgorithmException for all providers. - Update MessageDigest tests to use RandomFactory from http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/f8a3c1510f95/test/lib/testlibrary/jdk/t

Re: RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi Amanda, Tests look fine. Thanks for covering all these test vectors. One thing that I am not sure is the usage of @library, see below. Is this really used? I see the same in in both tests (.java) file. 21 * @library /sun/security/pkcs11 Thanks, Valerie On 5/19/2016 11:34 AM, Amanda Ji

RFR 8156059: Update/Develop new tests for JEP 287: SHA-3 Hash Algorithms

Hi All, Please help to review tests for JEP287: SHA-3 Hash Alogrithms. BugID: https://bugs.openjdk.java.net/browse/JDK-8156059 Webrev: http://cr.openjdk.java.net/~amjiang/8156059/webrev.01/ Test Plan: https://bugs.openjdk.java.net/browse/JDK-8068855 Thanks, Amanda