Not really. Will continue with it. I’m not sure whether Alan is done with it
either.
Brian
On Sep 12, 2016, at 8:34 PM, Weijun Wang wrote:
> Have you finished the deeper pass? :-)
>
> Thanks
> Max
>
> On 9/2/2016 8:18, Brian Burkhalter wrote:
>> At the API level and conceptually this all app
Have you finished the deeper pass? :-)
Thanks
Max
On 9/2/2016 8:18, Brian Burkhalter wrote:
At the API level and conceptually this all appears reasonable. I am
going to need to take a deeper pass over it all however to comprehend
the implementation at any kind of detailed level. The changes men
On 9/13/2016 2:13, Brian Burkhalter wrote:
Only picky comments: not sure but maybe change:
1) vice versa -> and vice versa
2) When it’s set to true -> When true
3) just like before -> as before
All accepted.
Thanks
Max
Brian
On Sep 12, 2016, at 12:23 AM, Weijun Wang mailto:weijun.w...@o
Only picky comments: not sure but maybe change:
1) vice versa -> and vice versa
2) When it’s set to true -> When true
3) just like before -> as before
Brian
On Sep 12, 2016, at 12:23 AM, Weijun Wang wrote:
> BTW, please also review the release note at
>
> https://bugs.openjdk.java.net/brows
BTW, please also review the release note at
https://bugs.openjdk.java.net/browse/JDK-8165836
Thanks
Max
On 9/1/2016 22:25, Weijun Wang wrote:
Webrev updated at
http://cr.openjdk.java.net/~weijun/8164705/webrev.01
At the API level and conceptually this all appears reasonable. I am going to
need to take a deeper pass over it all however to comprehend the implementation
at any kind of detailed level. The changes mentioned in response to Alan’s
comments all appear good.
Thanks,
Brian
On Sep 1, 2016, at 7:
Webrev updated at
http://cr.openjdk.java.net/~weijun/8164705/webrev.01
Most suggestions from Alan accepted, including:
1. Using SharedSecrets.getJavaIOFilePermissionAccess() style instead of
public functions.
2. jdk.io.permissionsUseCanonicalPath=.
3. samepath.sh rewritten in ReadFileOnP
On 8/29/2016 20:18, Alan Bateman wrote:
FilePermCompat is a ugly, particularly FilePermission changing its
public fields.
Do you prefer the traditional SharedSecrets way?
SharedSecrets.setJavaIoFilePermissionAccess(
new JavaIoFilePermissionAccessImpl());
Also method names like
Hi Alan
I am glad you think this change is useful.
As for the 3-value property, in my opinion even the absolute <=>
relative translation might not be really useful in a production
environment. Who can guarantee a program is always launched from a
certain directory and access a file using a re
On 25/08/2016 04:55, Weijun Wang wrote:
Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/8164705/webrev.00
From the beginning of JDK, FilePermission canonicalizes the input path
and use the result in implies() and equals(). This has been a big
performance hurt and leads to
Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/8164705/webrev.00
From the beginning of JDK, FilePermission canonicalizes the input path
and use the result in implies() and equals(). This has been a big
performance hurt and leads to confusing results when symlinks are invol
11 matches
Mail list logo
