Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-14 Thread Valerie Peng
Looks fine. Thanks, Valerie On 3/14/2017 1:24 AM, Amy Lu wrote: Looks good.Thank you Max! (I'm not a reviewer) Thanks, Amy On 3/14/17 3:37 PM, Weijun Wang wrote: How can you launch jtreg like this? :-) Anyway, I've updated the webrev at http://cr.openjdk.java.net/~weijun/8176296/webrev

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-14 Thread Amy Lu
Looks good.Thank you Max! (I'm not a reviewer) Thanks, Amy On 3/14/17 3:37 PM, Weijun Wang wrote: How can you launch jtreg like this? :-) Anyway, I've updated the webrev at http://cr.openjdk.java.net/~weijun/8176296/webrev.01 The test now creates the Java process itself so you won't be a

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-14 Thread Weijun Wang
How can you launch jtreg like this? :-) Anyway, I've updated the webrev at http://cr.openjdk.java.net/~weijun/8176296/webrev.01 The test now creates the Java process itself so you won't be able to manipulate it from outside. Thanks Max On 03/14/2017 12:02 PM, Amy Lu wrote: I looked at t

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-13 Thread Amy Lu
I looked at the new test: BasicLimited.java This test will fail if "jdk.security.jgss" is specified from jtreg javaoptions: jtreg ... -javaoptions:"--limit-modules java.security.jgss,jdk.security.auth,jdk.security.jgss" jdk9/test/sun/security/krb5/auto/BasicLimited.java Thanks, Amy On 3/14/

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-13 Thread Weijun Wang
Ping again. On 03/07/2017 10:10 PM, Weijun Wang wrote: Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be excluded using --limit-modules. Therefore I split

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-07 Thread Sergei Kovalev
Thanks that let me see. Good to know. 07.03.17 17:10, Weijun Wang wrote: Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be exclude using --limit-modules.

RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-07 Thread Weijun Wang
Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be exclude using --limit-modules. Therefore I split Basic.java into 2 and the new test has its own @modules