Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-06-15 Thread Sean Mullan
On 6/14/18 8:18 PM, Weijun Wang wrote: On Jun 15, 2018, at 2:19 AM, Sean Mullan wrote: Here are some comments so far. I should be able to finish reviewing this by tomorrow. - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java The Messag

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-06-14 Thread Weijun Wang
> On Jun 15, 2018, at 2:19 AM, Sean Mullan wrote: > > Here are some comments so far. I should be able to finish reviewing this by > tomorrow. > > - > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java The MessageDigest algorithms are r

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-06-14 Thread Sean Mullan
Here are some comments so far. I should be able to finish reviewing this by tomorrow. - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElement

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-06-13 Thread Weijun Wang
I've created my own Logger.java and LoggerFactory.java in com.sun.org.slf4j.internal. They has a slf4j-style interface but use java.util.logging.Logger inside. --Max [1] http://cr.openjdk.java.net/~weijun/8177334/webrev.01/src/java.xml.crypto/share/classes/com/sun/org/slf4j/internal/LoggerFact

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-06-13 Thread Sean Mullan
In StorageResolver.java: 41 private static final com.sun.org.slf4j.internal.Logger LOG = 42 com.sun.org.slf4j.internal.LoggerFactory.getLogger(StorageResolver.class); Shouldn't the previous code using java.util.logging.Logger be retained? There is no com.sun.org.slf4j package in the J

RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

2018-05-23 Thread Weijun Wang
Please review the change at webrev: http://cr.openjdk.java.net/~weijun/8177334/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8203460 New features include the support of SHA-224 and SHA-3 MessageMethod, and RSASSA-PSS SignatureMethods. The change is done in 2 steps: 1. Copying