Re: RFR 8199154: Accessibility issues in jdk.security.auth

2018-03-08 Thread Weijun Wang
> On Mar 9, 2018, at 11:30 AM, Valerie Peng wrote: > > > Line 196 of LdapLoginModule.java seems to miss a ? Maybe this is one of those inner tags (DD always inside DL) that will be automatically closed when its outer tag is closed? I'll add it anyway. Thanks.

Re: RFR 8199154: Accessibility issues in jdk.security.auth

2018-03-08 Thread Valerie Peng
Line 196 of LdapLoginModule.java seems to miss a ? Rest of webrev look fine. Valerie On 3/6/2018 5:38 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8199154/webrev.00/ In LdapLoginModule.java,

RFR 8199154: Accessibility issues in jdk.security.auth

2018-03-06 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8199154/webrev.00/ In LdapLoginModule.java, there seems to be an erroneous DL inside DL. I removed the outer DL and its incomplete DD. There is no visual difference after the change. In Krb5LoginModule.java, there were only DDs and