Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-10-08 Thread Weijun Wang
> On Oct 9, 2018, at 3:01 AM, Sean Mullan wrote: > > The first sentence is a bit terse. Suggest changing it to: > > "The `dns_canonicalize_hostname` flag in the krb5.conf configuration file is > now supported by the JDK Kerberos implementation." > > Also, you should probably spell out "FQDN

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-10-08 Thread Sean Mullan
The first sentence is a bit terse. Suggest changing it to: "The `dns_canonicalize_hostname` flag in the krb5.conf configuration file is now supported by the JDK Kerberos implementation." Also, you should probably spell out "FQDN". --Sean On 10/8/18 2:19 PM, Roger Riggs wrote: Hi Max, The r

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-10-08 Thread Roger Riggs
Hi Max, The release note is fine though it would more complete if it contained a link to the krb5_conf.html where the behavior is described. The original issue https://bugs.openjdk.java.net/browse/JDK-8210821 describes the behavior if set to 'false', while the release note is written describi

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-10-08 Thread Weijun Wang
And please also review the release note at https://bugs.openjdk.java.net/browse/JDK-8211380 The text is copied below: Supports the `dns_canonicalize_hostname` setting in krb5.conf. When set to true, a short hostname in a service principal name will be canonicalized to a FQDN if available. O

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-28 Thread Valerie Peng
Sure, I like the new simplified result. Changes look fine, Valerie On 9/26/2018 7:09 PM, Weijun Wang wrote: Webrev updated at https://cr.openjdk.java.net/~weijun/8210821/webrev.01. On Sep 26, 2018, at 11:57 PM, Weijun Wang wrote: Hi Valerie I've updated the CSR to remove the "always ca

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-26 Thread Weijun Wang
Webrev updated at https://cr.openjdk.java.net/~weijun/8210821/webrev.01. > On Sep 26, 2018, at 11:57 PM, Weijun Wang wrote: > > Hi Valerie > > I've updated the CSR to remove the "always canonicalize" choice and now the > default is "true", i.e. the current "smart-canonicalization" behavior. It

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-26 Thread Weijun Wang
Hi Valerie I've updated the CSR to remove the "always canonicalize" choice and now the default is "true", i.e. the current "smart-canonicalization" behavior. It's 12am here and I'll update the webrev tomorrow. Thanks Max > On Sep 18, 2018, at 8:52 AM, Valerie Peng wrote: > > Look fine to me.

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-17 Thread Weijun Wang
Thanks, I'll proposed the CSR next. --Max > On Sep 18, 2018, at 8:52 AM, Valerie Peng wrote: > > Look fine to me. Added myself to CSR as reviewer. > > Thanks, > > Valerie > > > On 9/17/2018 1:17 AM, Weijun Wang wrote: >> Please review the code change and CSR at >> >>http://cr.openjdk.j

Re: RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-17 Thread Valerie Peng
Look fine to me. Added myself to CSR as reviewer. Thanks, Valerie On 9/17/2018 1:17 AM, Weijun Wang wrote: Please review the code change and CSR at http://cr.openjdk.java.net/~weijun/8210821/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8210822 Thanks Max

RFR 8210821: Support dns_canonicalize_hostname in krb5.conf

2018-09-17 Thread Weijun Wang
Please review the code change and CSR at http://cr.openjdk.java.net/~weijun/8210821/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8210822 Thanks Max