https://bugs.openjdk.java.net/browse/JDK-8214024 filed.
Thanks
Max
> On Nov 17, 2018, at 3:56 AM, Sean Mullan wrote:
>
> Looks good. Please file a follow-on issue to remove the defaults.
>
> --Sean
>
> On 11/16/18 9:35 AM, Weijun Wang wrote:
>> Please take a review at
>>https://cr.openjdk
Looks good. Please file a follow-on issue to remove the defaults.
--Sean
On 11/16/18 9:35 AM, Weijun Wang wrote:
Please take a review at
https://cr.openjdk.java.net/~weijun/8212003/webrev.00/
Here, a warning is added when -keyalg is not specified, and some informational
text output that
> On Nov 16, 2018, at 11:48 PM, Sean Mullan wrote:
>
> On 11/15/18 10:20 PM, Weijun Wang wrote:
>> Would like also please review the release note here?
>> https://bugs.openjdk.java.net/browse/JDK-8213965
>
> I made a few changes. I think it is important to also say that we will be
> removi
On 11/15/18 10:20 PM, Weijun Wang wrote:
Would like also please review the release note here?
https://bugs.openjdk.java.net/browse/JDK-8213965
I made a few changes. I think it is important to also say that we will
be removing support for the default values in a subsequent release.
I ha
Please take a review at
https://cr.openjdk.java.net/~weijun/8212003/webrev.00/
Here, a warning is added when -keyalg is not specified, and some informational
text output that were only available in verbose mode is now always printed.
Below are the exact output you will see after this change.
Would like also please review the release note here?
https://bugs.openjdk.java.net/browse/JDK-8213965
I had thought about using RN-Deprecated but there is no API here. If you think
it's better, I'll use it and also change all "obsolete" into "deprecate" in the
description and title of the rel
Thanks to Xuelei and Sean. I added your recommended words and proposed the CSR.
> On Nov 15, 2018, at 6:16 AM, Sean Mullan wrote:
>
> On 11/14/18 5:07 AM, Weijun Wang wrote:
>> The CSR is re-opened. It is now focusing on -keyalg only. Please take a
>> review:
>>https://bugs.openjdk.java.net
On 11/14/18 5:07 AM, Weijun Wang wrote:
The CSR is re-opened. It is now focusing on -keyalg only. Please take a review:
https://bugs.openjdk.java.net/browse/JDK-8212111
I think the CSR should also include an example of the informational text
showing what algs and size were used. Looks goo
I may want to have the warning message with more explicit guide to
cleanup the warning. For example:
Warning: No -keyalg option. The default key algorithm ...
Otherwise, looks fine to me.
I added myself as the reviewer.
Thanks,
Xuelei
On 11/14/2018 2:07 AM, Weijun Wang wrote:
The CSR i
The CSR is re-opened. It is now focusing on -keyalg only. Please take a review:
https://bugs.openjdk.java.net/browse/JDK-8212111
Thanks
Max
> On Nov 7, 2018, at 11:51 PM, Weijun Wang wrote:
>
> Oops, I take this back. The CSR needs more update.
>
> Sorry if you have already start reading i
The CSR looks fine to me. Thanks.
-coderaptor
On Wed, Nov 7, 2018 at 7:53 AM Weijun Wang wrote:
>
> Oops, I take this back. The CSR needs more update.
>
> Sorry if you have already start reading it.
>
> Thanks
> Max
>
>
> > On Nov 7, 2018, at 9:27 AM, Weijun Wang wrote:
> >
> > After some discus
Oops, I take this back. The CSR needs more update.
Sorry if you have already start reading it.
Thanks
Max
> On Nov 7, 2018, at 9:27 AM, Weijun Wang wrote:
>
> After some discussion, we decided to cover -keysize and -sigalg in this
> deprecation process too.
>
> Please review the updated CSR
After some discussion, we decided to cover -keysize and -sigalg in this
deprecation process too.
Please review the updated CSR at
https://bugs.openjdk.java.net/browse/JDK-8212111
No webrev available yet.
Thanks
Max
> On Oct 18, 2018, at 10:34 AM, Weijun Wang wrote:
>
> Please review th
> On Oct 18, 2018, at 10:34 AM, Weijun Wang wrote:
>
> Please review the code change and CSR for
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8212003
>
> at
>
> webrev: http://cr.openjdk.java.net/~weijun/8212003/webrev.00/
> CSR: https://bugs.openjdk.java.net/browse/JDK-8212111
Please review the code change and CSR for
JBS: https://bugs.openjdk.java.net/browse/JDK-8212003
at
webrev: http://cr.openjdk.java.net/~weijun/8212003/webrev.00/
CSR: https://bugs.openjdk.java.net/browse/JDK-8212111
When -keyalg is not provided for -genkeypair or -genseckey, keytool wi
15 matches
Mail list logo
