Re: RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

2018-10-22 Thread Weijun Wang
Maybe noreg-trivial is for lazy people. I'll remove it and add a comment. Thanks Max > On Oct 22, 2018, at 11:30 PM, Sean Mullan wrote: > > Looks fine to me. It is unusual to have two noreg labels on a bug. Is that > acceptable? I would probably choose one or the other. noreg-hard seems more

Re: RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

2018-10-22 Thread Sean Mullan
Looks fine to me. It is unusual to have two noreg labels on a bug. Is that acceptable? I would probably choose one or the other. noreg-hard seems more appropriate to me. --Sean On 10/15/18 9:34 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8212216/webr

RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

2018-10-15 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8212216/webrev.00/ This bug is reported and fixed by Nico Williams . No regression test, memory leak. Thanks Max