Re: RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

2018-11-16 Thread Sean Mullan
On 11/15/18 10:33 AM, Adam Petcher wrote: Done[1]. Please take a look when you have a chance. [1] https://bugs.openjdk.java.net/browse/JDK-8213946 Looks fine. --Sean On 11/14/2018 4:29 PM, Sean Mullan wrote: The fix and the CSR look good. Please also add a release note. --Sean On 11/8/1

Re: RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

2018-11-15 Thread Adam Petcher
Done[1]. Please take a look when you have a chance. [1] https://bugs.openjdk.java.net/browse/JDK-8213946 On 11/14/2018 4:29 PM, Sean Mullan wrote: The fix and the CSR look good. Please also add a release note. --Sean On 11/8/18 11:51 AM, Adam Petcher wrote: Oops. And the JBS ticket: https://

Re: RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

2018-11-14 Thread Sean Mullan
The fix and the CSR look good. Please also add a release note. --Sean On 11/8/18 11:51 AM, Adam Petcher wrote: Oops. And the JBS ticket: https://bugs.openjdk.java.net/browse/JDK-8213363 On 11/8/2018 11:43 AM, Adam Petcher wrote: webrev: http://cr.openjdk.java.net/~apetcher/8213363/webrev.00/

Re: RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

2018-11-08 Thread Adam Petcher
Oops. And the JBS ticket: https://bugs.openjdk.java.net/browse/JDK-8213363 On 11/8/2018 11:43 AM, Adam Petcher wrote: webrev: http://cr.openjdk.java.net/~apetcher/8213363/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8213493 This change fixes a bug related to the encoded format of X

RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

2018-11-08 Thread Adam Petcher
webrev: http://cr.openjdk.java.net/~apetcher/8213363/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8213493 This change fixes a bug related to the encoded format of X25519/X448 private keys. The new code will not preserve compatibility with the improperly-formatted keys produced by th