RFR 8234267: DelegationPermission implementation doesn't completely follow the updated specification

2019-11-16 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8234267/webrev.00/ Here, the returnDelims argument of the StringTokenizer is true so that we can detect duplicated delimiters. If I understand correctly, after every non-delimiter token, the next one MUST be a delimiter. Therefore I

Re: RFR 8234267: DelegationPermission implementation doesn't completely follow the updated specification

2019-12-02 Thread Weijun Wang
Ping again. > On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8234267/webrev.00/ > > Here, the returnDelims argument of the StringTokenizer is true so that we can > detect duplicated delimiters. > > If I understand correct

Re: RFR 8234267: DelegationPermission implementation doesn't completely follow the updated specification

2019-12-04 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 12/2/2019 11:15 PM, Weijun Wang wrote: Ping again. On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8234267/webrev.00/ Here, the returnDelims argument of the StringTokenizer is true so that w

Re: RFR 8234267: DelegationPermission implementation doesn't completely follow the updated specification

2019-12-04 Thread Weijun Wang
Thanks! > On Dec 5, 2019, at 2:32 AM, Xuelei Fan wrote: > > Looks fine to me. > > Thanks, > Xuelei > > On 12/2/2019 11:15 PM, Weijun Wang wrote: >> Ping again. >>> On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote: >>> >>> Please take a review at >>> >>> http://cr.openjdk.java.net/~weijun/8