Re: RFR 8240848: ArrayIndexOutOfBoundsException buf for TextCallbackHandler

2020-04-08 Thread Sean Mullan
On 4/7/20 10:32 PM, Weijun Wang wrote: I'd removed the change on ConfirmationCallback. Will address it in another fix together with some other similar changes. Webrev updated in-place. Please take a review. Looks good. --Sean Thanks, Max On Mar 12, 2020, at 9:21 PM, Weijun Wang wrote:

Re: RFR 8240848: ArrayIndexOutOfBoundsException buf for TextCallbackHandler

2020-04-07 Thread Weijun Wang
I'd removed the change on ConfirmationCallback. Will address it in another fix together with some other similar changes. Webrev updated in-place. Please take a review. Thanks, Max > On Mar 12, 2020, at 9:21 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~

Re: RFR 8240848: ArrayIndexOutOfBoundsException buf for TextCallbackHandler

2020-04-03 Thread Weijun Wang
Ping again. > On Mar 12, 2020, at 9:21 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8240848/webrev.00/ > > The problem is that selection has a different meaning for a specified > optionType (the option value) and an unspecified one (the option in

RFR 8240848: ArrayIndexOutOfBoundsException buf for TextCallbackHandler

2020-03-12 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8240848/webrev.00/ The problem is that selection has a different meaning for a specified optionType (the option value) and an unspecified one (the option index). I also take this chance to make ConfirmationCallback more robust. Than