Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

2020-05-30 Thread Weijun Wang
Thanks. Updated and pushed. --Max > On May 31, 2020, at 10:03 AM, Xuelei Fan wrote: > > Looks good to me. You may also want to update the copyright date in KDC.java. > > Xuelei > > On 5/30/2020 4:54 AM, Weijun Wang wrote: >> Please take a review at >>http://cr.openjdk.java.net/~weijun/82

Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

2020-05-30 Thread Xuelei Fan
Looks good to me. You may also want to update the copyright date in KDC.java. Xuelei On 5/30/2020 4:54 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible there

Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

2020-05-30 Thread Martin Balao
On 5/30/20 8:54 AM, Weijun Wang wrote: > Please take a review at > >http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ > > While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible > there is no PA-DATA at all. This could happen when preauth is turned off. > I'm not a

RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

2020-05-30 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible there is no PA-DATA at all. This could happen when preauth is turned off. Thanks, Max