Re: RFR JDK8007636

2013-06-18 Thread Valerie (Yu-Ching) Peng
I recall reviewing this use-after-free problem a while ago? Isn't this the same one that's caught by parfait earlier? The synopsis for 8007636 is "[parfait] False positive buffer overrun error in jdk/src/solaris/transport/socket/socket_md.c". Your changes do not seem to match the bug description

Re: RFR JDK8007636

2013-06-18 Thread Florian Weimer
On 06/17/2013 04:29 PM, John Zavgren wrote: Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it deallocated the memory that was allocated to one of its data members. I merely reversed the order

Re: RFR JDK8007636

2013-06-17 Thread Brad Wetmore
Ditto. brad On 6/17/2013 5:16 PM, Xuelei Fan wrote: Looks fine to me. Thanks, Xuelei On 6/17/2013 10:29 PM, John Zavgren wrote: Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it dealloc

Re: RFR JDK8007636

2013-06-17 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 6/17/2013 10:29 PM, John Zavgren wrote: > Greetings: > > I'm posting a fix for a memory leak. As you can see, the original code > deallocated a structure, thereby rendering it's memory invalid, then it > deallocated the memory that was allocated to one of its

RFR JDK8007636

2013-06-17 Thread John Zavgren
Greetings: I'm posting a fix for a memory leak. As you can see, the original code deallocated a structure, thereby rendering it's memory invalid, then it deallocated the memory that was allocated to one of its data members. I merely reversed the order of the free() operations. http://cr.ope