Re: 6998583 Code review request

2010-11-25 Thread Seán Coffey
Makes sense Andrew. Will take into account before pushing final changes. regards, Sean. On 25/11/2010 00:31, Dr Andrew John Hughes wrote: On 25 November 2010 00:29, Dr Andrew John Hughes wrote: On 22 November 2010 14:20, Vincent Ryan wrote: Fix looks good Sean. On 22/11/2010 13:50, Seán C

Re: 6998583 Code review request

2010-11-24 Thread Dr Andrew John Hughes
On 25 November 2010 00:29, Dr Andrew John Hughes wrote: > On 22 November 2010 14:20, Vincent Ryan wrote: >> Fix looks good Sean. >> >> On 22/11/2010 13:50, Seán Coffey wrote: >>> Brad, Vinnie, >>> >>> This is a forward port of 6998583 to JDK 7. Can you review ? >>> >>> http://cr.openjdk.java.net/

Re: 6998583 Code review request

2010-11-24 Thread Dr Andrew John Hughes
On 22 November 2010 14:20, Vincent Ryan wrote: > Fix looks good Sean. > > On 22/11/2010 13:50, Seán Coffey wrote: >> Brad, Vinnie, >> >> This is a forward port of 6998583 to JDK 7. Can you review ? >> >> http://cr.openjdk.java.net/~coffeys/6998583/webrev.6998583.0/ >> >> Thanks, >> Sean. > > In:

Re: 6998583 Code review request

2010-11-22 Thread Vincent Ryan
Fix looks good Sean. On 22/11/2010 13:50, Seán Coffey wrote: > Brad, Vinnie, > > This is a forward port of 6998583 to JDK 7. Can you review ? > > http://cr.openjdk.java.net/~coffeys/6998583/webrev.6998583.0/ > > Thanks, > Sean.