On 05/11/2016 06:46 PM, Anthony Scarpino wrote:
Please review the changes related to 8154005. This is a continuation
JEP-288. It adds a denyAfter constraint the stops PKIX algorithm
support at a specified date.
http://cr.openjdk.java.net/~ascarpino/8154005/webrev/
A few minor comments on the
Thanks Anthony!
On 13.05.2016 19:04, Anthony Scarpino wrote:
Hi Ivan,
I added your comments.. I had thought usePattern() wouldn't reuse the
entry, but apparently the description is not the way I read it.
You comments are incorporated into the webrev.01 that I posted previously
Looks good
Hi Ivan,
I added your comments.. I had thought usePattern() wouldn't reuse the
entry, but apparently the description is not the way I read it.
You comments are incorporated into the webrev.01 that I posted previously
thanks
Tony
On 05/12/2016 04:13 PM, Ivan Gerasimov wrote:
Hi Anthony!
Hi Anthony!
A few minor comments:
*AlgorithmChecker.java*
It would be more consistent to use {@code ...} tags in place of
...
*DisabledAlgorithmConstraints.java*
275 Matcher dmatch = denyAfterPattern.matcher(entry);
296 } else if (dmatch.matches()) {
It might be a bit more efficient to
I've updated the webrev to at:
http://cr.openjdk.java.net/~ascarpino/8154005/webrev.01/
Comments addressed below...
On 05/11/2016 04:55 PM, e...@zusammenkunft.net wrote:
Hello,
In AlgorithmChecker the Javadoc seems to not follow "@param name
desc" format (in two places). Also it should most
Hello,
In AlgorithmChecker the Javadoc seems to not follow "@param name desc" format
(in two places). Also it should most likely describe something like "time the
signature claimed to be made to check time range limited ciphers after that
date or similiar)
* @param PKIXParameter timestamp (or
