Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-03-24 Thread Florian Weimer
On 03/21/2014 06:28 PM, Andrew Hughes wrote: I still think it's better to remove the dlopen/dlsym machinery and use dynamic linking instead. I've provided that as an option in IcedTea, but it then means that a different PCSC implementation can't be swapped in. I think you can still use LD_

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-03-21 Thread Andrew Hughes
- Original Message - > On 02/04/2014 04:48 PM, Andrew Hughes wrote: > > > As has already been mentioned on this thread, libraries should have their > > version increased when the ABI changes. Thus, a libpcsclite.so.2 or later > > would indicate a different ABI to what the JDK PCSC code w

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-02-11 Thread Florian Weimer
On 02/04/2014 04:48 PM, Andrew Hughes wrote: As has already been mentioned on this thread, libraries should have their version increased when the ABI changes. Thus, a libpcsclite.so.2 or later would indicate a different ABI to what the JDK PCSC code was written for. Now, it may be that the code

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-02-04 Thread Andrew Hughes
- Original Message - > > Won't this change break systems which don't have libpcsclite.so.1? > Changes like this need to be thought through. What happens when > libpcsclite.so.2 comes out? > As for API changes, shouldn't there be some compatibility requirement on > APIs as libpcsclite.so ev

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Florian Weimer
On 04/25/2013 12:11 AM, Valerie (Yu-Ching) Peng wrote: Won't this change break systems which don't have libpcsclite.so.1? By linking against libpcsclite.so.1 at the ELF level? Yes. But the dependency is already there, it is just not expressed explicitly, so it will not be discovered by tools

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Severin Gehwolf
Hi Valerie, Thanks for the review! On Wed, 2013-04-24 at 15:11 -0700, Valerie (Yu-Ching) Peng wrote: > Won't this change break systems which don't have libpcsclite.so.1? Yes. However, currently it breaks systems which don't have libpcsclite.so. [1] would be an example. There is a system property

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-25 Thread Severin Gehwolf
On Wed, 2013-04-24 at 13:05 +0200, Florian Weimer wrote: > On 03/01/2013 11:30 AM, Severin Gehwolf wrote: > > Hi, > > > > The bug for this review request is at: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 > > > > In PlatformPCSC.java unversioned native libraries are loaded by def

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Valerie (Yu-Ching) Peng
Won't this change break systems which don't have libpcsclite.so.1? Changes like this need to be thought through. What happens when libpcsclite.so.2 comes out? As for API changes, shouldn't there be some compatibility requirement on APIs as libpcsclite.so evolves? Valerie On 04/24/13 04:05, Fl

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Florian Weimer
On 03/01/2013 11:30 AM, Severin Gehwolf wrote: Hi, The bug for this review request is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 In PlatformPCSC.java unversioned native libraries are loaded by default if no system property is specified. This could lead to a JVM crash if the

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-04-24 Thread Severin Gehwolf
On Fri, 2013-03-01 at 11:30 +0100, Severin Gehwolf wrote: > Hi, > > The bug for this review request is at: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 > > In PlatformPCSC.java unversioned native libraries are loaded by default > if no system property is specified. This could lead

Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2013-03-01 Thread Severin Gehwolf
Hi, The bug for this review request is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 In PlatformPCSC.java unversioned native libraries are loaded by default if no system property is specified. This could lead to a JVM crash if the API of the native library changes, but the Java c