Ok to me.
Xuelei
> On Feb 17, 2014, at 9:57 PM, Sean Mullan wrote:
>
>> On 02/14/2014 08:52 PM, Xuelei Fan wrote:
>> AdaptableX509CertSelector.java
>> ==
>> 1. for boolean value checking, I normally use
>>if (boolean-value) or if (!boolean-value)
>
> I usually d
On 02/14/2014 08:52 PM, Xuelei Fan wrote:
AdaptableX509CertSelector.java
==
1. for boolean value checking, I normally use
if (boolean-value) or if (!boolean-value)
I usually do too, but "== false" seemed more readable to me in this
code, perhaps because it is im
AdaptableX509CertSelector.java
==
1. for boolean value checking, I normally use
if (boolean-value) or if (!boolean-value)
2. AdaptableX509CertSelector.match(Certificate)
KID can be used to facilitate the path building. I would suggest
check the SKID and SN at fir
On 2/14/14 7:17 AM, Sean Mullan wrote:
On 02/13/2014 10:04 PM, Jason Uh wrote:
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
Sure.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.ja
On 02/13/2014 10:04 PM, Jason Uh wrote:
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
Sure.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.java read "As for version 3,..." and
not "
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.java read "As for version 3,..." and
not "As for version 2,..."?
2. Just curious, any re
See: http://cr.openjdk.java.net/~mullan/webrevs/8025708/webrev/
This fixes a problem with the PKIX CertPathBuilder where it wasn't able
to build a path when the Authority Key Identifier extension of an
intermediate CA cert did not contain a serial number field, and the end
entity cert did.
T
