Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Sean Mullan
Looks fine though you missed updating the copyright date on the test. --Sean On 8/25/11 9:44 PM, Weijun Wang wrote: [ Add security-dev@openjdk.java.net to CC] I think so. javax/xml/crypto is public API and it should go to jdk_security2 (along with javax/crypto). Of course, that is still

Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Weijun Wang
On 08/26/2011 09:15 PM, Sean Mullan wrote: Looks fine though you missed updating the copyright date on the test. Recently I form a new habit of not touching copyright years at all, so that a changeset can be ported to another version with no change at all. -Max --Sean On 8/25/11 9:44

Re: code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-26 Thread Sean Mullan
On 8/26/11 9:42 AM, Weijun Wang wrote: On 08/26/2011 09:15 PM, Sean Mullan wrote: Looks fine though you missed updating the copyright date on the test. Recently I form a new habit of not touching copyright years at all, so that a changeset can be ported to another version with no change

code review request: 7083576 (was Re: no javax/xml/crypto jprt test targets in jdk/test/Makefile)

2011-08-25 Thread Weijun Wang
[ Add security-dev@openjdk.java.net to CC] I think so. javax/xml/crypto is public API and it should go to jdk_security2 (along with javax/crypto). Of course, that is still not included in the default run. I've filed a bug: 7083576: add javax/xml/crypto into jdk_security2 test rule and