Hello Valerie,
Your changes look good.
Thanks.
On 06/ 9/12 01:08 AM, Valerie (Yu-Ching) Peng wrote:
Vinnie,
Could you please review the changes for 7044060 "Need to support NSA
Suite B Cryptography algorithms"?
The webrev is at:
http://cr.openjdk.java.net/~valeriep/7044060/webrev.00/
The cha
Changeset: d87e86aaf2b3
Author:andrew
Date: 2012-08-08 12:37 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d87e86aaf2b3
7189533: GetJavaProperties should free temporary file if subsequent allocations
fails
Summary: Add missing calls to free
Reviewed-by: alanb, dholmes, sher
Hi Valerie,
Thank you for agreeing to take a look at this suggested change.
Please get back to me as soon as you have any questions, comments or
observations on this.
Thanks,
Neil
On Fri, 2012-07-27 at 17:15 -0700, Valerie (Yu-Ching) Peng wrote:
> Neil,
>
> Thanks for the feedback, I will take
Changeset: a50e92a980a5
Author:alanb
Date: 2012-08-08 15:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50e92a980a5
7189886: (aio) Add test coverage for AsynchronousChannelGroup.withThreadPool
Reviewed-by: alanb
Contributed-by: [email protected]
! test/java/nio/channels/
Changeset: a44671e0b6d7
Author:ksrini
Date: 2012-08-08 09:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7
7189944: (launcher) test/tools/launcher/Aghs.java needs a couple of minor
fixes
Reviewed-by: darcy, jgish
! test/tools/launcher/Arrrghs.java
! test/t
Changeset: f071cd32d297
Author:sundar
Date: 2012-08-08 22:17 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f071cd32d297
7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}
Reviewed-by: darcy, jjg
! src/share/classes/com/sun/tools/javac/tree/TreeInfo
Please review the design of JEP 114, TLS Server Name Indication (SNI)
Extension.
The webrev: http://cr.openjdk.java.net./~xuelei/7068321/webrev_spec.01/
The following is a list of typical user cases, and the demo code using
this spec for each case.
Typical user cases for client side:
Case 1: I
Max,
The new ordering for reading the config files sounds reasonable.
However, I have questions on scenarios where the various config files
don't exist and the corresponding handling.
The new impl of getJavaFileName()/getNativeFileName() return file names
even when the file doesn't exist.
This
On 08/09/2012 10:10 AM, Valerie (Yu-Ching) Peng wrote:
Max,
The new ordering for reading the config files sounds reasonable.
However, I have questions on scenarios where the various config files
don't exist and the corresponding handling.
The new impl of getJavaFileName()/getNativeFileName() r
