Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-23 Thread John Zavgren
Greetings: I've modified the procedure "Java_com_sun_security_auth_module_UnixSystem_getUnixInfo" so that all four GetFieldID calls must be successful before it attempts to call "Set" methods. This new program logic ensures that this procedure returns successfully if and only if all the informa

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-23 Thread Dmitry Samersoff
John, Good work! Thank you for doing it. Looks good for me! -Dmitry On 2012-10-23 12:56, John Zavgren wrote: > Greetings: > I've modified the procedure > "Java_com_sun_security_auth_module_UnixSystem_getUnixInfo" so that all four > GetFieldID calls must be successful before it attempts to ca

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-23 Thread Chris Hegarty
On 10/23/2012 10:03 AM, Dmitry Samersoff wrote: John, Good work! Thank you for doing it. Yes John, thanks for the extra effort, this is much cleaner ( and as you say also fixes the leak ). -Chris. Looks good for me! -Dmitry On 2012-10-23 12:56, John Zavgren wrote: Greetings: I've mod

hg: jdk8/tl/jdk: 8000204: Memory leak in com/sun/security/auth/module/Unix.c

2012-10-23 Thread chris . hegarty
Changeset: 29b58cb8e4fc Author:chegar Date: 2012-10-23 11:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29b58cb8e4fc 8000204: Memory leak in com/sun/security/auth/module/Unix.c Reviewed-by: dsamersoff, wetmore, khazra, chegar Contributed-by: John Zavgren ! src/solaris/n

RFR 8000476, miscellaneous leaks, access to uninitialized memory, etc

2012-10-23 Thread John Zavgren
Greetings: Please review the following webrev image that contains repairs for various sins against memory: leaks, access to uninitialized memory, etc. http://cr.openjdk.java.net/~chegar/8000476/webrev.00/ Thanks! John Zavgren [email protected]

Re: RFR 8000476, miscellaneous leaks, access to uninitialized memory, etc

2012-10-23 Thread Dmitry Samersoff
John, java_md_solinux.c you probably need to add JLI_MemFree(newargv); before line 485 also. Otherwise looks good. -Dmitry On 2012-10-23 20:03, John Zavgren wrote: > Greetings: > > Please review the following webrev image that contains repairs for various > sins against memory: leaks, acc

hg: jdk8/tl/jdk: 7197071: Makefiles for various security providers aren't including the default manifest

2012-10-23 Thread bradford . wetmore
Changeset: 940c8cc5a5c4 Author:wetmore Date: 2012-10-23 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4 7197071: Makefiles for various security providers aren't including the default manifest Reviewed-by: valeriep, mullan, katleman ! make/com/oracle/securi

Re: RFR 8000476, miscellaneous leaks, access to uninitialized memory, etc

2012-10-23 Thread Valerie (Yu-Ching) Peng
For GSSLibStub.c, line 573, major should be assigned w/ 0. Although GSS_C_QOP_DEFAULT also has the same value, but it means something different. The PKCS11 changes look fine. Thanks, Valerie On 10/23/12 09:03, John Zavgren wrote: Greetings: Please review the following webrev image that conta

hg: jdk8/tl/langtools: 8000416: refactor javadoc to provide and use an abstraction for relative URIs

2012-10-23 Thread jonathan . gibbons
Changeset: 4a1c57a1c410 Author:jjg Date: 2012-10-23 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a1c57a1c410 8000416: refactor javadoc to provide and use an abstraction for relative URIs Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/htm

8001419: Build the JCE portion of JDK-8000970

2012-10-23 Thread Brad Wetmore
I have stripped out the JCE portion of: http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-October/001547.html and am integrating it for Fredrik, and doing the internal JCE builds. The work will be done under: 8001419: Build the JCE portion of JDK-8000970 Summary: Original code done by Fred

hg: jdk8/tl/jdk: 8001419: Build the JCE portion of JDK-8000970

2012-10-23 Thread bradford . wetmore
Changeset: 13b46e8eda33 Author:ohrstrom Date: 2012-10-23 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b46e8eda33 8001419: Build the JCE portion of JDK-8000970 Summary: Original code done by Fredrik Ohrstrom, separated/pushed by wetmore Reviewed-by: wetmore ! src/sh